search

Memmy-App / memmy

An Apollo inspired open-source iOS and Android client for Lemmy built with React-Native. Find us on the App Store and Google Play!
GNU Affero General Public License v3.0
547 stars 58 forks source link

[Bug]: Post and comment context menu button too small #1068

Closed ftatateeta closed 8 months ago

ftatateeta commented 8 months ago

Check for open issues

Minimal reproducible example

Trying to tap on the context menu buttons for comment or post results in failure half the time because they're too small.

Expected Behavior

Shouldn't be that hard to tap on the context menu button.

Version

1.1.78

App Store or TestFlight?

App Store

iOS Version

17.x

Device

iphone x

ftatateeta commented 8 months ago

Thanks for the quick fix but did you mean to close the other issue? https://github.com/Memmy-App/memmy/issues/1067

gkasdorf commented 8 months ago

@ftatateeta Yea, I fixed that too đź‘Ť

gkasdorf commented 8 months ago

Oh...you're right. Sorry. Fixing this one as we speak, got them mixed up.

ftatateeta commented 8 months ago

Awesome!

gkasdorf commented 8 months ago

@ftatateeta Ok, I applied some changes that I feel like are improve this. I'm going to leave this open though and ask for your opinion once the update is available (submitted something to Testflight, but its a new version number so will need to be approved by Apple. Usually fairly quick these days).

Feels fine to me but... darn users and their different sized fingers 🤣

ftatateeta commented 8 months ago

Thanks I'll take a look later when I get a chance. I thought we could add invisible padding to increase the button area without increasing the icon size as well. I think that's how apps usually do it since the actual button is usually bigger than the visual icon size to make it easier to tap. Anyway I don't know if that's necessary I'll give it a try.

gkasdorf commented 8 months ago

Admittedly I was slightly lazy here and tried doing it with an invisible SVG. Adding padding will increase spacing and sort of mess up the positioning of elements. I plan to go through and take time making every specific UI piece look better, so at that time I’d definitely try to take the ellipsis into account (the issue is the height of it is obviously rather small)But if this doesn’t feel right we can just go ahead and do something about it now 👍GavinSent from my iPhoneOn Nov 6, 2023, at 17:08, ftatateeta @.***> wrote: Thanks I'll take a look later when I get a chance. I thought we could add invisible padding to increase the button area without increasing the icon size as well. I think that's how apps usually do it since the actual button is usually bigger than the visual icon size to make it easier to tap. Anyway I don't know if that's necessary I'll give it a try.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

ftatateeta commented 8 months ago

I just tried it it's a lot better now. Thank you!