search

Memmy-App / memmy

An Apollo inspired open-source iOS and Android client for Lemmy built with React-Native. Find us on the App Store and Google Play!
GNU Affero General Public License v3.0
548 stars 58 forks source link

[BUG] Attempting to copy/share an image only shares its URL #146

Closed PgBiel closed 1 year ago

PgBiel commented 1 year ago

Describe the bug Not sure if this was intentional or not, but, when attempting to share an image, I can only share its URL instead of the image itself. There surely might be uses in sharing an image's URL (and this could remain as an option somewhere, maybe in the share menu), but I believe the most common use case is to share the image itself (e.g. to WhatsApp to share to friends).

To Reproduce Steps to reproduce the behavior:

  1. Go to a post with an image, e.g. https://pawb.social/post/195693
  2. Click on the image to show download/share options
  3. Click on the share button to the right, displaying the share menu
  4. Try to share the image to another app, or to copy it
  5. Notice that the image's URL was shared/copied, not the image itself (despite, at times, advertising the image itself is being shared).

Expected behavior The image itself should have been shared.

Screenshots

1. Entering the linked post

2. Clicking on the image

3. Clicking on the share button (it advertises the image is being shared)

4. Attempting to share (note just the URL was shared)

Smartphone (please complete the following information):

Logs: (no logs)

Additional context As an Apollo immigrant, I have to say this app ticks all the right boxes. I was just a bit surprised by this behavior, as Apollo does it as one would expect (sharing the image itself).

Apollo also had a feature to download videos, but I guess that could be an eventual feature request instead.

gkasdorf commented 1 year ago

Going to fix this right now along with the animation issue https://github.com/gkasdorf/memmy/issues/156

PgBiel commented 1 year ago

Hey @gkasdorf, thanks for the quick response! Did the fix make it into version 73 (released today)? I've updated to it, but the issue still seems to be there. (Just making sure!)

PgBiel commented 1 year ago

Hello @gkasdorf, this bug still seems to be present on the latest versions (attempting to share images only shares their links on 0.0.2 (16)). Could you reopen this issue? Thanks.

gkasdorf commented 1 year ago

I don't know why this was closed actually but I'm literally working on it as we speak haha. Should be done in a few hours.

PgBiel commented 1 year ago

Gotcha! Sorry for bothering you haha. Thank you for the hard work, and for the great app!

gkasdorf commented 1 year ago

@PgBiel And...done https://github.com/Memmy-App/memmy/commit/3d1a0e05327558a02665fe5a1ff8f41235163a2a

PgBiel commented 1 year ago

Thank you!! I will make sure to test it and give feedback as soon as it's out 🙂.

PgBiel commented 1 year ago

Hey @gkasdorf, just wanted to give my feedback here. The feature is working! Thanks! Yay 🎉🎉🎉

Just one observation: it seems that there is oftentimes a somewhat large delay between clicking the share button and the share menu actually appearing (due to downloading the image, I imagine); do you think some sort of progress indicator (or at least a throbber) could be added in (if that's not too hard to do)? Thanks again :)

gkasdorf commented 1 year ago

Haha literally just put this in the todo list. Will be in next update :)

PgBiel commented 1 year ago

Oh goodness... great minds think alike I guess? Hahaha

I will be on the wait! Thanks for all your effort, it is certainly appreciated :)