search

Memmy-App / memmy

An Apollo inspired open-source iOS and Android client for Lemmy built with React-Native. Find us on the App Store and Google Play!
GNU Affero General Public License v3.0
548 stars 58 forks source link

Report Post Option Misbehaves #577

Closed ainen closed 1 year ago

ainen commented 1 year ago

Describe the bug When opening the “Report Post” view, it looks different than the “Block Community” view. The only way to exit the “Report Post” view is to tap cancel, tapping anywhere else does nothing.

To Reproduce Steps to reproduce the behavior:

  1. Go to a post
  2. Tap the three dot icon
  3. Attempt to exit by tapping anywhere except the “Cancel” button.

Expected behavior Tapping anywhere should close the “Report Post” button instead of just the “Cancel” button.

Screenshots image image

Smartphone (please complete the following information):

eoddc5 commented 1 year ago

@gkasdorf this is similar to my other Bug issue

But it’s generally the same thing. Menus are not facing the same look and behavior

eoddc5 commented 1 year ago

@Felix-Staud since you linked a PR to this, I am going to close #511 , so we only have one active issue open for the same bug

can you please ensure that the scope of this PR includes other items from #511 

In a post, if you click the … menu button, there’s no haptics

You can’t close the menu pop up by clicking outside the bounds. Only by hitting cancel

Closing the menu doesn’t produce haptics

At the same time, the comments … menu in a post WILL produce haptics on click. You can escape the menu by clicking on the sceen outside of it OR hitting the cancel button. And there’s a haptic feedback on close.

Would be great to reproduce the same behavior on the post menu that is there on the comments menu (comments menu actions are nicer ux)

The menu's are also different visually (with a space between actions and cancel on comments ... , but no space in post)
flx-sta commented 1 year ago

@eoddc5 I'll have to make a new PR as that one was already merged. Here is a tasklist to follow