Ensure you've checked the following before submitting your PR:
[ ] You've discussed making your changes with a member of the dev team per contributing rules in the README
[x] Your changes are free of any lint errors
[x] Your changes are free of any typescript errors
[x] You've tested your changes
Summary
Please provide a summary of what your PR does
This changes the interfaces ITheme field initialColorMode to accept undefined instead if the string "unspecified", which caused typescript errors several places.
Since undefined is supported by keyboardAppearance, ActionSheets and tint (which is where this field used today), I think this is a more sensible fallback for themes without a initalColorMode.
Screenshots
If the UI has been changed, include screenshots.
We will not review your PR without screenshots if they are applicable.
Not applicable.
Test Plan
Please documemnt the steps required to test your PR
joshua-davis-rose
commented
1 year ago
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
This changes the interfaces
IThemefieldinitialColorModeto acceptundefinedinstead if the string"unspecified", which caused typescript errors several places.Since
undefinedis supported bykeyboardAppearance, ActionSheets andtint(which is where this field used today), I think this is a more sensible fallback for themes without ainitalColorMode.Screenshots
Not applicable.
Test Plan
There shouldn't be any visible changes.