Memnarch / Delphinus

An alternative Packagemanager for the Delphi-IDE
Mozilla Public License 2.0
237 stars 64 forks source link

[External timelines] Author name #52

Open Pawe1 opened 7 years ago

Pawe1 commented 7 years ago

IMHO when Delphinus.Info.json contains repository section, author name should be taken from repository\user because owner of repository with *.json don't have to be the real author 😁

Memnarch commented 7 years ago

I know. But since that field has to be lower caps, i'll probably favor an "Author" field in the info file. Not sure yet.

Pawe1 commented 7 years ago

What is the cause of need for lower caps?

Is Github case-insensitive?

Look here: (this works) https://github.com/Pawe1/Delphinus.Links.ZXing/blob/master/Delphinus.Info.json

Memnarch commented 7 years ago

it works for WebURLs, but the APIs are very strict and case sensitive

Pawe1 commented 7 years ago

@Memnarch So... do I have to change it to lower case?

Memnarch commented 7 years ago

Quote from my WIKI:

user: The username of the repository to link to. Only lowercase letters. name: The name of the repository to link to. Only lowercase letters.

Pawe1 commented 7 years ago

I saw that and I wanted to figure out why / what would happen if I use original case :wink:

Memnarch commented 7 years ago

oh and please, try to get the original package authors to host their packages :P Otherwhise one day you disappear and leave a trail of ghostpackages :P

Pawe1 commented 7 years ago

I tried... Discussion is here: https://github.com/Spelt/ZXing.Delphi/pull/52

For now I don't want to add this package manager or any other package managers. Maintenance will always be some kind of an issue. Maybe in a few months. You can clone it and spread it from there if you like. I have no problems with that.

I don't like to force people. Some of them are just not too much convinced...

When You'll fix displaying author name I can send him info + screenshot and add as collaborator to this repository.

Memnarch commented 7 years ago

Than please do the following: Make an Organization. Give those people complete write access(tell them you'll maintain but they still have the ownership then). Or instead of an organization i think you can give write permissions to your repos aswell. But don't just create these repos without giving the authors complete control please :/

Memnarch commented 7 years ago

And please keep in mind to properly add the current release and all that come in the future

Pawe1 commented 7 years ago

As I told - it is a test. First of all I'd like author name to be displayed properly :smile: And then I want to continue conversation with author

Organization - maybe it's a good idea... I have never used this

Memnarch commented 7 years ago

well if its a test: why is it already visible :P Don't add testpackages. There is a singlerepo provider you can use within the code instead of the normal one and give it the url for one specific repository(which then ofcourse does not need the support-keyword)

Pawe1 commented 7 years ago

Because I wanted to make it working, take screenshots and show working thing to the author and then talk to him & offer full access to this repository & already properly published package. There is no other way to test it properly. Also this is working / points to the original repository / and author said

You can clone it and spread it from there if you like. I have no problems with that.

Only displaying credits does not work. And I want that guy who created this to be specified because it's a piece of nice code.

Pawe1 commented 7 years ago

Maybe I'll have some time in afternoon to try fix this "Author" issue

Memnarch commented 7 years ago

i have no problem with you cloning it, but in case you disappear someone needs the rights to pull the trigger :P

And the Singlerepoprovider loads it like everyother package. You could even mod it a pit to load a specific repo in addition to the rest. After iterating the normal provider, get the package form the singlerepoprovider and add that to the UI, too

Pawe1 commented 7 years ago

BTW I think that if package number grows You'll have to figure out some way of central controlling / GUID reservation system... This experiment shows that currently it is really easy to create hundreds of potential ghost clone packages

Memnarch commented 7 years ago

this has always been possible and is possible everywhere. If you want to abuse it, you can :P And i do have some ideas ;)

Memnarch commented 7 years ago

Btw i think i'll add a new property: Maintainer. Therefore showing that a specific package is developed by pseron A but the package is Maintained by Person B.

Maintainers for example are listed on other packagesystems like for Linux(ArchLinux). EDIT: But i think i'll keep Author as a synonym for "PackageAuthor" and introduce a property for "Developer". Still thinking about it.

Pawe1 commented 6 years ago

I created Pull Request with some workaround Check it out :wink:

Pawe1 commented 6 years ago

<bump>