Add verification of requirements to install

Memnarch / Delphinus

An alternative Packagemanager for the Delphi-IDE

Mozilla Public License 2.0

235 stars 64 forks source link

Add verification of requirements to install #70

Open BakasuraRCE opened 5 years ago

BakasuraRCE commented 5 years ago

I can't install Delphinus from webinstaller, i installed from source.

Log:

<Info> Downloading Delphinus
<Info> Version: 
<Info> BDS 20.0
<Info> Uninstalling
<Info> Deleting Directory C:\Program Files (x86)\Delphinus\20.0
<Info> Installing
<Info> Copying sourcefolders:
<Info> .
<Info> Compiling Delphinus.dproj
<Info> Win32
<Info> 
<Error> Failed
<Info> Adding Libpathes:
<Error> Failed

BakasuraRCE commented 5 years ago

I verified in deep, the problem was this line: https://github.com/Memnarch/Delphinus/blob/927fba619149d6a1b7c9c887db4d18b3c5b1accd/DN.Compiler.MSBuild.pas#L56

When the system does not have installed "msbuild" tool, it will silently fail and in the following line no log any error report to show to user, just fail:

https://github.com/Memnarch/Delphinus/blob/927fba619149d6a1b7c9c887db4d18b3c5b1accd/DN.Compiler.MSBuild.pas#L84