Memphiz / xbmc

XBMC Main Repository
http://xbmc.org
Other
55 stars 18 forks source link

Derive the app group ID from the main bundle ID #26

Closed DanTheMan827 closed 8 years ago

DanTheMan827 commented 8 years ago

@Memphiz This enables my iOS App Signer to properly sign the app with a working top shelf.

Memphiz commented 8 years ago

Great work - about to try it out in a min!

Memphiz commented 8 years ago

i hope its ok for you that this commit will be squashed down into the tvos platform file cpmmit on my next rebase? (i try to keep the whole branch ready to do a PR to mainline)

DanTheMan827 commented 8 years ago

To use it with iOS app signer the provisioning profile has to have an app group named group..shared where \ is the app id

So basically create the blank project, fix issue, go to capabilities, add an app group with that template and then resign (Xcode will have created duplicates though)

DanTheMan827 commented 8 years ago

You could actually remove the .shared from the app group name, now that I think about it that would probably be simpler for the how to because it would just be group.appid

Memphiz commented 8 years ago

yep - adapted accordingly (last commit)

Memphiz commented 8 years ago

i also kicked a new jenkins build ... have to go now for a while - feel free to download it from the mirrors and try it out :)

DanTheMan827 commented 8 years ago

I would do that but it's 4:13AM here ;)

Also, you seem to be stuck on using confluence for the skin... Is that a bug or a change in Kodi master?

And some binary addons are incompatible due to api change (pvr.wmc is an example)

Memphiz commented 8 years ago

stuck to confluence sounds like a bug ... the incompatible api is a "feature" of cooking in master while its heavily changed ;) ... go to bed i suggest ;)

Memphiz commented 8 years ago

I see what you mean - there is no "more" button in the skin selection anymore ... strange

DanTheMan827 commented 8 years ago

There are also no skins in the repository and if you install a zip it doesn't change

IF you package a skin in the app and change the default setting it changes

But change back to confluence and you can't change back

I've only tested this with the estuary preview so...

Memphiz commented 8 years ago

Its the same on master - i verified it on osx a min ago ...

Memphiz commented 8 years ago

I confirmed the skin issue. We have switched to the krypton repo. ATM there is no compatible skin with the krypton API, thats why you can't get more.