VideoSync - change in behavior?!? Or does it work at all?

[Memphiz]

The last time i helped implementing the videosyncosx i think i remember doing the following test:

1. Drove both monitors with different refreshrates.
2. Enabled sync to display in player settings.
3. Started video playback
4. Enabled the video debug overlay (which showed the detected refreshrate)
5. Moved the window between the screens.
6. Back then we implemted it that way, that the detected refreshrate was updated automagically when moving between the screens.

Observation with current branch:

1. When playing back in windowed mode on a 75hz screen - videosyncosx detects 60hz
2. When moving the window between screens - nothing seems to change
3. When going fullscreen - nothing seems to change.

I can't find that real time debug display anymore, but just looked into the debug log.

Either something got badly broken in the refactor, or it got broken before, or the behavior changed somewhere else.

@FernetMenta any idea? (for testing this you need to pull from the branch because i readded the GetVideoSync method in windowing which got lost ...)

[Memphiz]

mhh i enabled refresh rate adaption in addition to "sync to display" - at least it now detects the correct refreshrate from the display - but its not updated when i move the window between the screens.

This is the code that was supposed to tell kodi that the refreshrate might have changed:

https://github.com/xbmc/xbmc/blob/osxremovesdl/xbmc/windowing/osx/OSXScreenManager.mm#L641

[FernetMenta]

I haven't looked into this so far

[github-actions[bot]]

This issue is now marked stale because it has been open over a year without activity. Remove the stale label or add a comment to reset the stale state.