Add a missing header (because of changes in gnome-panel.h)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Build the file-browser-applet with gnome-panel >= 2.25.90
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
0.6.0

Please provide any additional information below.
Upstream gnome-panel has remove support for libgnome from ver. 2.25.90, and
gnome-panel.h thus no longer include the lignome header necessary for
file-browser-applet to build. The attached patch includes the missing
header, allowing the package to continue to build.
I'm not sure if file-browser-applet also plans to drop libgnome dependency  

Original issue reported on code.google.com by dakin...@gmail.com on 4 Feb 2009 at 6:23

Attachments:

• fba-libgnome.patch

[GoogleCodeExporter]

Hey Deji,

I (though I had) dropped the dependency on any lib with gnome in the name 
(gnome-vfs,
gnome-ui, etc.) when I switched to gio. I may have to check again, but I'm 
pretty
sure I'm not using any gnome libs.

I'm on intrepid so can't reproduce the error you get. Could you send me the
compilation error message please so I can track down the offending code? At 
least it
should be in main.c

Original comment by bertol...@gmail.com on 4 Feb 2009 at 8:06

• Changed state: Accepted

[GoogleCodeExporter]

Hi,

I've cut out the error portion below;

>>
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c: In function
'file_browser_applet_display_about_dialog':
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c:100: warning: 
implicit
declaration of function 'gnome_program_locate_file'
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c:100: error:
'GNOME_FILE_DOMAIN_PIXMAP' undeclared (first use in this function)
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c:100: error: (Each
undeclared identifier is reported only once
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c:100: error: for each
function it appears in.)
/builddir/build/BUILD/file-browser-applet-0.6.0/src/main.c:100: warning: 
assignment
makes pointer from integer without a cast
make[2]: *** [src/CMakeFiles/file-browser-applet.dir/main.o] Error 1
make[2]: Leaving directory 
`/builddir/build/BUILD/file-browser-applet-0.6.0/fedora'
make[1]: *** [src/CMakeFiles/file-browser-applet.dir/all] Error 2
make[1]: Leaving directory 
`/builddir/build/BUILD/file-browser-applet-0.6.0/fedora'
make: *** [all] Error 2
<<

Original comment by dakin...@gmail.com on 4 Feb 2009 at 8:47

[GoogleCodeExporter]

Deji,

Fix is in svn.

Got rid of gnome_program_locate_file. The only other thing that relies on any 
Gnome
lib is gnome_help_display_desktop_on_screen, but its disabled by default. So, it
should compile fine now.

Please try it out and let me know.
Thanks.

Original comment by bertol...@gmail.com on 8 Feb 2009 at 8:06

• Changed state: Started

[GoogleCodeExporter]

Closing...

Original comment by bertol...@gmail.com on 13 Feb 2009 at 11:46

• Changed state: Fixed