search

Menci / vite-plugin-wasm

Add WebAssembly ESM integration (aka. Webpack's `asyncWebAssembly`) to Vite and support `wasm-pack` generated modules.
MIT License
281 stars 16 forks source link

feat: support Vite 5 #45

Closed wyatt-herkamp closed 9 months ago

wyatt-herkamp commented 9 months ago

It is not working on Legacy Browsers the tests for Legacy browser is failing. If you know how to fix this please help.

I did updated the other dependencies.

@babel/preset-env wanted a peer dependency of @babel/core

aljazerzen commented 9 months ago

@Menci Can this be merged?

FYI: legacy browser tests fail on my machine as well

Menci commented 9 months ago

Thanks. I'll check it soon.

wyatt-herkamp commented 9 months ago

I propose we have a new major release and drop Vite 2/3. And Node 14/16.

Menci commented 9 months ago

@aljazerzen @wyatt-herkamp Now everything should just work. Please check it and after then I'll merge and release it.

For the broken test, it's because the upgrade of playwright. I'm not sure it's the issue of playwright or corresponding version of Firefox that simulation of a legacy browser with dom.moduleScripts.enabled isn't working. Just pinning playwright's version does the fix.

wyatt-herkamp commented 9 months ago

Tested against my website it worked fine. Test Suite passed too.