MendelXu / ANN

semantic segmentation,pytorch,non-local
Apache License 2.0
312 stars 63 forks source link

Losses #10

Closed bluesky314 closed 4 years ago

bluesky314 commented 4 years ago

Your losses.py at https://github.com/MendelXu/ANN/blob/master/models/seg/loss/seg_modules.py has a number of different loss functions including some for embedding layers which are not mentioned in your paper. Could you kindly provide some explanation for what these losses mean? Would love to learn more about them, they seem quite interesting. Thanks!

bluesky314 commented 4 years ago

@MendelXu You referenced you used hard-mining strategy and referenced to the PSPnet paper, however PSPnet has no hard-mining losses like you. Can you please clarify your reference and the source of the losses?

MendelXu commented 4 years ago

Your losses.py at https://github.com/MendelXu/ANN/blob/master/models/seg/loss/seg_modules.py has a number of different loss functions including some for embedding layers which are not mentioned in your paper. Could you kindly provide some explanation for what these losses mean? Would love to learn more about them, they seem quite interesting. Thanks!

Sorry for the late reply. Although there are many loss functions provided in this file, we don't use those such as FocalLoss, Encoding Loss. It is just cloned from https://github.com/donnyyou/torchcv. If you are interested in that, maybe you can refer to the original repository.

@MendelXu You referenced you used hard-mining strategy and referenced to the PSPnet paper, however PSPnet has no hard-mining losses like you. Can you please clarify your reference and the source of the losses?

I'm sorry it is not very clear in our paper but We didn't refer the hard minging strategy to PSPNet. It appears frequently in semantic segmentation repository and we don't find the source of that. If you find the source of that, may you post here? And we'll correct it in our paper

bluesky314 commented 4 years ago

Thanks for clarification. Can you tell what online hard minning you did? Is it only focal loss or something else as well?

On Wednesday, December 4, 2019, MendelXu notifications@github.com wrote:

Your losses.py at https://github.com/MendelXu/ANN/blob/master/models/seg/ loss/seg_modules.py has a number of different loss functions including some for embedding layers which are not mentioned in your paper. Could you kindly provide some explanation for what these losses mean? Would love to learn more about them, they seem quite interesting. Thanks!

Sorry for the late reply. Although there are many loss functions provided in this file, we don't use those such as FocalLoss, Encoding Loss. It is just cloned from https://github.com/donnyyou/torchcv. If you are interested in that, maybe you can refer to the original repository.

@MendelXu https://github.com/MendelXu You referenced you used hard-mining strategy and referenced to the PSPnet paper, however PSPnet has no hard-mining losses like you. Can you please clarify your reference and the source of the losses?

I'm sorry it is not very clear in our paper but We didn't refer the hard minging strategy to PSPNet. It appears frequently in semantic segmentation repository and we don't find the source of that. If you find the source of that, may you post here? And we'll correct it in our paper

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MendelXu/ANN/issues/10?email_source=notifications&email_token=AIOBDNDPSHX76GHL745QNJDQW53DXA5CNFSM4JTQ4J4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4K6SQ#issuecomment-561557322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOBDNFNWLPDFI64V4ZV4LDQW53DXANCNFSM4JTQ4J4A .

MendelXu commented 4 years ago

You can refer to this function.https://github.com/MendelXu/ANN/blob/f4eabeb27dbba5c9bdcf83d03776bffa34995666/models/seg/loss/seg_modules.py#L58 It just computes the loss of the pixels which are hard. Focal loss should work too, but we didn't try this.

Thanks for clarification. Can you tell what online hard minning you did? Is it only focal loss or something else as well? On Wednesday, December 4, 2019, MendelXu @.***> wrote: Your losses.py at https://github.com/MendelXu/ANN/blob/master/models/seg/ loss/seg_modules.py has a number of different loss functions including some for embedding layers which are not mentioned in your paper. Could you kindly provide some explanation for what these losses mean? Would love to learn more about them, they seem quite interesting. Thanks! Sorry for the late reply. Although there are many loss functions provided in this file, we don't use those such as FocalLoss, Encoding Loss. It is just cloned from https://github.com/donnyyou/torchcv. If you are interested in that, maybe you can refer to the original repository. @MendelXu https://github.com/MendelXu You referenced you used hard-mining strategy and referenced to the PSPnet paper, however PSPnet has no hard-mining losses like you. Can you please clarify your reference and the source of the losses? I'm sorry it is not very clear in our paper but We didn't refer the hard minging strategy to PSPNet. It appears frequently in semantic segmentation repository and we don't find the source of that. If you find the source of that, may you post here? And we'll correct it in our paper — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AIOBDNDPSHX76GHL745QNJDQW53DXA5CNFSM4JTQ4J4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4K6SQ#issuecomment-561557322>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOBDNFNWLPDFI64V4ZV4LDQW53DXANCNFSM4JTQ4J4A .