search

Mendeley / mrec

A recommender systems development and evaluation package by Mendeley
Other
562 stars 174 forks source link

Python 3 compatibility #13

Open jseabold opened 8 years ago

jseabold commented 8 years ago

Tests pass. Might need some more work. Haven't tried it much yet.

chriskilding commented 8 years ago

Hi @jseabold we have just added Travis CI to auto build our project. If you pull in our latest changes from master, then edit the .travis.yml file section that sets the Python version to go from this:

python:

to simultaneously testing a Python 2 + 3 version of your choice, like this:

python:

Then Travis will non-destructively apply the changes in your pull request on top of the current master, and we can see if the build and tests still pass with your changes included.

jseabold commented 8 years ago

Rebased. Let's see.

chriskilding commented 8 years ago

It looks like multiple Python 2/3 compatibility libraries are in use. 'future' is used in some places and that dependency is present. But 'six' is used in others, and that's not yet declared in the install_requires array in setup.py, hence missing dependency error.

jseabold commented 8 years ago

Failures look related? I have too new a numpy to test locally it looks like.