MengTo / DesignerNewsApp

Build a Swift App as a designer
http://designcode.io
2.42k stars 367 forks source link

Use SafariViewController instead of WebView #129

Open alexkaessner opened 8 years ago

alexkaessner commented 8 years ago

Would be nice to use the iOS 9 SafariViewController instead of the WebView to benefit from the new features of it. At least a small option to use it would be great.

PS: Is the app still maintained? We've seen no commit for a long time.

avihard commented 5 years ago

I appreciate your question but i'm thinking that it is not good to see a webView just because of it is application so safari browser seems awkward.

alexkaessner commented 5 years ago

@avikorat Beside the fact that the app isn't even available anymore, I'm not sure if I understand your answer right.

Most apps use a SFSafariViewController these days to present web content. This brings a lot of advantages over the custom WKWebView. As Apple also says:

If your app lets users view websites from anywhere on the Internet, use the SFSafariViewController class. If your app customizes, interacts with, or controls the display of web content, use the WKWebView class.

The DesignerNewsApp just displayed websites and did not customize the contents.