MengTo / Spring

A library to simplify iOS animations in Swift.
http://designcode.io
MIT License
14.08k stars 1.8k forks source link

Doesn't working at swift 5 #329

Open Pirokar opened 5 years ago

pigpox commented 5 years ago

same issue here

wxforgb commented 5 years ago

same issue

NSDAPP commented 5 years ago

Works fine here. Just had to unlock the files and let xcode auto-fix the errors.

Pirokar commented 5 years ago

Do you really mean that it's a good solution? What about commits to git? Or you will say, that we should to use flash card instead?))

NSDAPP commented 5 years ago

The complaints I was getting from xcode, where just due to re-namings. It has not given me any issue so far. commits have also worked fine. It might not be the correct fix, but it works for now and allows me to continue my work :-) If i find any issues with this I will let you know

ccascio commented 5 years ago

Auto-fix didn't work for me; in the file Misc.swift, I had to comment this line of code: public var length: Int { return self.characters.count } replacing the .length with the swift OoTB function .count As well as fixing the line 76: switch (hex.characters.count) { simply with switch hex.count {

pigpox commented 5 years ago

OoTB

how did you fix the .length ? example pls...

pigpox commented 5 years ago

hmm....var length: Int { return self.count }

Surferdude667 commented 5 years ago

@MengTo Would be incredibly awesome with a swift 5 update soon! :)

arensade commented 5 years ago

just change pod lib swift version to 4.2.

MussaCharles commented 5 years ago

I forked the project and migrated to Swift 5 on my repo, I will make a pull request soon. Meanwhile, you can get Swift 5 version by pointing to my repo like so: - pod 'Spring', :git => 'https://github.com/MussaCharles/Spring.git'

AmirHossein1372 commented 5 years ago

This guide worked: Swift version

fatihyildizhan commented 4 years ago

I try to use swift 5 branch pod 'Spring', :git => 'https://github.com/MengTo/Spring.git', :branch => 'swift5' but when I run the project it crashes immediately.

imbaTao commented 3 years ago

use_frameworks! pod 'Spring', :git => 'https://github.com/MengTo/Spring.git', :branch => 'swift5'

https://github.com/MengTo/Spring/tree/swift5