MengeCrowdSim / MengeCS

C-Sharp bindings for Menge
5 stars 10 forks source link

Add `pluginPath` param to `Initialize` method #8

Open alafi opened 6 years ago

alafi commented 6 years ago

The changes are:

  1. Add pluginPath param to Initialize method in Simulator class with default to null.
  2. Deleted the local copy of MengeCore_d.dll and enhanced the pre-build events to copy the dll that matches the build configuration from the external folder for both MengeCS and MengeCSExe projects.

This should also close issue #7


This change is Reviewable

curds01 commented 6 years ago

I really appreciate you doing this. It's great to have you give back to the community. I particularly like the refactoring of sourcing the dlls directly from the menge directory.

However, this feels like two different PRs fixing two different issues:

So, I have the following recommendations: