Open alafi opened 6 years ago
I really appreciate you doing this. It's great to have you give back to the community. I particularly like the refactoring of sourcing the dlls directly from the menge directory.
However, this feels like two different PRs fixing two different issues:
The first addresses the issue you had in #7.
MengeWrapper.cs
doesn't reference it. So, even if I build this in Debug mode, the project will still access the release version of MengeCore.dll
.The second adds the plug-in path to the CS bindings.
sha
of the upstream repository it depends on so that they are kept clearly in sync.So, I have the following recommendations:
The changes are:
pluginPath
param toInitialize
method inSimulator
class with default tonull
.MengeCore_d.dll
and enhanced the pre-build events to copy the dll that matches the build configuration from the external folder for bothMengeCS
andMengeCSExe
projects.This should also close issue #7
This change is