Implementation of function getCustomRandom() is faulty.

MengelCode / finalfate

**The Final Fate** A space game in HTML5 and JavaScript.

https://manuel-engel.de/finalfate/finalfate

Other

9 stars 5 forks source link

Implementation of function getCustomRandom() is faulty. #153

Closed MengelCode closed 1 year ago

MengelCode commented 1 year ago

In the JavaScript code snippet shared as well in the copy the function is used in this project, it has a flaw....because of max being exclusive, the max value is not possible. Function needs to be corrected in all projects and in the new project the flaw was actually detected.

MengelCode commented 1 year ago

Looked in the other (not public) project....seems there will then be two implementations for two purposes.

MengelCode commented 1 year ago

Wrong function is even called in level 4 "loader". This got some mess...