MenghaoGuo / PCT

Jittor implementation of PCT:Point Cloud Transformer
661 stars 80 forks source link

How is the positional embedding implemented? #24

Open YifanDengWHU opened 3 years ago

YifanDengWHU commented 3 years ago

Hi, I want to ask how is positional embedding implemented in the model? xyz = self.pos_xyz(xyz) but there isn't self.pos_xyz given

amiltonwong commented 3 years ago

It seems no positional encoding is implemented in this PCT model...

MenghaoGuo commented 3 years ago

self.pos_xyz can be a simple MLP networks e.g., two fully-connected layers.

marshzero commented 3 years ago

I wonder if the self.pos_xyz on 165 line same as self.conv_pos on 146 line in /networks/cls/pct.py