MenoData / Time4J

Advanced date, time and interval library for Java with sun/moon-astronomy and calendars like Chinese, Coptic, Ethiopian, French Republican, Hebrew, Hijri, Historic Christian, Indian National, Japanese, Julian, Korean, Minguo, Persian, Thai, Vietnamese
GNU Lesser General Public License v2.1
424 stars 62 forks source link

Ignoring option: -useuniqueclassmembernames #907

Closed iamcalendar closed 4 years ago

iamcalendar commented 4 years ago

In the case of enabling minify, we encounter the following warning when building our Android library (AAR):

AGPBI: {"kind":"warning","text":"Ignoring option: -useuniqueclassmembernames","sources":[{"file":"C:\Users\Amir\.gradle\caches\transforms-2\files-2.1\ad48a65f216623fc684f793154f00d44\jetified-time4j-android-4.6-2020a\proguard.txt","position":{"startLine":0,"startColumn":0,"startOffset":0,"endColumn":26,"endOffset":26}}],"tool":"R8"}

This is related to the first line of consumer-proguard-rules.pro file: -useuniqueclassmembernames

Would this cause any problem? Is there any workaround?

MenoData commented 4 years ago

I don't think this will cause any problem if ignored. It is a valid option of Proguard in obfuscating context, see also the relevant section for useuniqueclassmembernames in the documentation.

But I agree, in case you really observe any serious problem then I can of course remove the line in the proguard file. It is not very important. By the way, I have recently updated my Android Studio to v4.0.0 and will check any relevant warnings left soon.

iamcalendar commented 4 years ago

Thank you for your attention.