WIP: Display (& Select) Side Dishes

MensaToday / mensa-today

Daily mensa recommendations for students and lecturers in Münster/Germany.

GNU General Public License v3.0

4 stars 0 forks source link

WIP: Display (& Select) Side Dishes #204

Closed lgiesen closed 1 year ago

lgiesen commented 1 year ago

@MarcelRe9 Please check, why the date is not displayed correctly.

This is how the side dishes look:

martenjostmann commented 1 year ago

@lgiesen Maybe display the side dishes only as a list without the images

martenjostmann commented 1 year ago

Also the date is not important for the side dishes

lgiesen commented 1 year ago

Also the date is not important for the side dishes

The date is not included for the side dishes.

lgiesen commented 1 year ago

@lgiesen Maybe display the side dishes only as a list without the images

I like the images and would like to keep them.

MarcelRe9 commented 1 year ago

@lgiesen Date should be fixed now in frontend/recommendations-page

erikzimmermann commented 1 year ago

@lgiesen Maybe display the side dishes only as a list without the images

I like the images and would like to keep them.

I'd prefer having a smaller more compact popup for side dishes where you can select them easier.

Also, it would be very nice if the prices of main and side dish are summed up to compare it with your card balance.

lgiesen commented 1 year ago

@lgiesen Maybe display the side dishes only as a list without the images

I like the images and would like to keep them.

I'd prefer having a smaller more compact popup for side dishes where you can select them easier.

Also, it would be very nice if the prices of main and side dish are summed up to compare it with your card balance.

Since I use the main & side dishes as one component, it would be a little more complicated to implement the sum of the side dish and main dish. Since 1€ is added on top of the dish price, it would still cover any side dishes because all/most of them cost under 1€. Nevertheless, nice idea!

lgiesen commented 1 year ago

Screenshot 2023-01-21 at 13 53 19

martenjostmann commented 1 year ago

How should the selection process look like? Currently it is not obvious that the user can click on the side dishes. Also the most recommendable side dish should be highlighted.

martenjostmann commented 1 year ago

@lgiesen See #210 for api changes

lgiesen commented 1 year ago

The weekday does not work (in Firefox at least). @MarcelRe9, could you take a look at it?

lgiesen commented 1 year ago

How should the selection process look like? Currently it is not obvious that the user can click on the side dishes. Also the most recommendable side dish should be highlighted.

How should the selection feature look like? We don't have a selection API call, so what should the frontend do?

MarcelRe9 commented 1 year ago

The weekday does not work (in Firefox at least). @MarcelRe9, could you take a look at it?

Should be fixed now