MenthorTools / menthor-editor

Menthor Editor
30 stars 7 forks source link

default import configurations to import all classes #67

Closed BernardoFBBraga closed 8 years ago

BernardoFBBraga commented 8 years ago

now, as default, if someone selects a xmi file and clicks on parse file, no classes are imported.

the user must first click on the "Filter" tab, click on "import to menthor" then select the classes he wishes to import, only then click on parse file.

We should have as default to import all classes in the model, so the user doesn't need to click on the filter tab.

Selecting the file and clicking on "parse file" should filter the model and import everything by default

johnguerson commented 8 years ago

The thing is, the 'parse' button actually do the parsing of the XMI syntax. So the Tree in the 'Filter' tab is only created _After _the Parse Button is clicked. If we change the 'parse' button to be the 'Import' button, we have to make sure the tree is loaded when the dialog prompts, no problem with that, however, if an error appear in the XMI parsing (in the dialog creation), the 'settings' dialog will not even appear, just an error message. Is this behaviour okay? If so, I can change this in a bit @BernardoFBBraga

BernardoFBBraga commented 8 years ago

@johnguerson I did not understand your suggestion.

The functionality of the buttons is confusing.

I suggest hiding the "filter" tab. After parsing, show the filter tab and hide the "parser" tab.

"Check" all classes to be imported by default on the "filter" tab and leave the tree open by default

tgoprince commented 8 years ago

@BernardoFBBraga

Acho que já acertaram esse problema. Dá uma conferida e se tiver ok aí, fecha a issue! :smile:

BernardoFBBraga commented 8 years ago

All classes are selected by default now, which solves the issue so I am marking it as closed.

However, the confusion with the purpose of each button remains. Clicking on "Import to Menthor" before parsing results in parsing. Clicking on "parse" after parsing the first time results in importing to menthor.