search

Menturan / MMM-OpeningHours

Magic Mirror module that displays places opening hours.
GNU General Public License v3.0
12 stars 3 forks source link

Upgrade opening_hours dependency ? #32

Open arthurlutz opened 1 year ago

arthurlutz commented 1 year ago

OpeningHours doesn't display anymore for me. I get : 

[11.11.2022 11:43.03.691] [ERROR] An error occurred during evaluation of the value "Tu 16:15-18:30, We 10:00-12:30, We 13:30-18:30, Th 16:15-18:30, Fr 16:15-18:30, Sa 10:00-12:30, Sa 13:30-17:00; PH off; SH Tu 16:00-18:30, We 10:00-12:00, We 13:30-18:30, Th 10:00-12:00, Th 16:00-18:30, Fr 16:00-18:30". Please submit a pull request: https://github.com/opening-hours/opening_hours.js. School holiday not defined for the year 2022.

I think opening_hours should be upgraded ?

It seems that holidays for 2022 are in https://github.com/opening-hours/opening_hours.js/blob/master/src/holidays/fr.yaml#L390

But maybe this is not included in the 3.7.0 release https://github.com/opening-hours/opening_hours.js/releases ?

arthurlutz commented 1 year ago

I posted an issue on the dependency too : https://github.com/opening-hours/opening_hours.js/issues/434