search

MenuDocs / Pyro

A Python Discord Bot
Apache License 2.0
25 stars 6 forks source link

Dev improv (fixes #1, #2 and #3). #4

Closed ribosomerocker closed 4 years ago

ribosomerocker commented 4 years ago

@Skelmis @MelodicAlbuild preview code and tell me if you like the code or not, make comments about code that you dont like/think can be improved and i can fix it.

ribosomerocker commented 4 years ago

Do not merge though, not yet.

Skelmis commented 4 years ago

I am aware that the rtfm command has a default search string, however I still thing the usage should be included in the decorator such that

@commands.command(
    name="rtfm",
    description="Gives you a documentation link for a d.py entity."
    aliases=['rtfd'],
    usage="<Term to get doc link for>"
    )

Or something to that means

ribosomerocker commented 4 years ago

Usually overcomplicating it is never the right way so just adding more words to the usage isnt exactly the right way to go with this. if anything, I'd just put in <query> or something.

ribosomerocker commented 4 years ago

AND even then, I dont think I'll hardcode it into the usage string. I'll just change the variable name so that it makes more sense to the users. dpy automatically parses it as the usage anyways, sooo... There isnt exactly any need except for weirdly adding hardcoded stuff and text into it while dpy already bases it off our variable names, if you feel strongly about it though we can find a way to get something better

Skelmis commented 4 years ago

Just means changing the help command round for how its formatted, shouldnt be an issue. If you know how to parse it better please comment it on my pr in a bit. Otherwise ill figure it out tomorrow

ribosomerocker commented 4 years ago

Merged and closing. @Skelmis make sure to use git rebase -i in your terminal in the directory where this project is on your branch for you to catch all changes (also run black on it again just in-case)