search

MenuDocs / Pyro

A Python Discord Bot
Apache License 2.0
25 stars 6 forks source link

Migrated to nextcord and added thread support #41

Closed Auxtal closed 2 years ago

Auxtal commented 2 years ago

Pyro will now automatically join any threads created in any python support channels. It is also now running on the latest version of nextcord as of me making this pull request (2.0.0a3).

I have also updated the readme to use a more efficient command for deploying on docker. I have tested the thread joining and some commands and all seems to work well on nextcord.

The buttons lib works fine with nextcord as of now. If anyone wants to do some more testing of commands with the bot running on nextcord feel free.

My auto code formatter black also updated some of the command decorators.

i-am-zaidali commented 2 years ago

Two queries

  1. Why aren't we using bot_base here?
  2. Not really a query, but for ease of transferring to nextcord I was planning to change imports as such: import nextcord as discord :joy:
Auxtal commented 2 years ago

Two queries

  1. Why aren't we using bot_base here?
  2. Not really a query, but for ease of transferring to nextcord I was planning to change imports as such: import nextcord as discord 😂

No need for bot base right now, we could use it in future. Using import nextcord as discord probably is not the best of practices as it makes the code harder to understand and troubleshoot. And it's all done now anyways so no big deal.

Skelmis commented 2 years ago

Two queries

1. Why aren't we using bot_base here?

Little out of scope for this pr, however I could be keen to implement it in another pr.

Skelmis commented 2 years ago

You will also need to rebase now

Auxtal commented 2 years ago

Should be good to merge now.