MenuDocs / Pyro

A Python Discord Bot
Apache License 2.0
26 stars 6 forks source link

Add black app to immediately disable PRs if black formatting isnt followed #6

Closed ribosomerocker closed 4 years ago

ribosomerocker commented 4 years ago

Add a black python formatting integration to check for black styling and fix stuff, as well as stop merges if black is not ran on them

Skelmis commented 4 years ago

Could we take this a step further in that any code committed that doesn't follow black formatting is automatically changed?

Skelmis commented 4 years ago

Could use something such as a pre-commit thing, see the bottom of this https://www.mattlayman.com/blog/2018/python-code-black/

ribosomerocker commented 4 years ago

Yes, thank you!

ribosomerocker commented 4 years ago

@Skelmis Can you implement this feature and close this issue once its good? I'll be checking the new commits in the db integration branch

Skelmis commented 4 years ago

Ill take a geez and attempt to implement in the morning sure thing

Skelmis commented 4 years ago

For everyone, I need you to do the following. pip install pre-commit

Then in git bash run pre-commit install