MeoMix / StreamusChromeExtension

A YouTube video player as a Google Chrome extension
http://streamus.com
Apache License 2.0
1.08k stars 216 forks source link

Fix shuffle + radio mode interactions #280

Open MeoMix opened 10 years ago

MeoMix commented 10 years ago

This is a little tricky to get right and will require some additional thought.

I think it should be something like:

The actual % will need a bit of playing to feel right. It shouldn't be 50/50 as you almost assuredly want to discover new music more than repeating if you have radio on, but maybe I'm wrong!

It's also worth considering how the 'repeat' button would interact with all of this. Maybe 'repeat all' is ignore entirely, but 'repeat song' wins out 100%? The only thing I worry about is being sure to not stop playback once shuffled through all songs in playlist once.

fluke commented 10 years ago

If there are n songs you can have a 1/(n+1) chance of a new song being pulled out of the radio. And shuffle as normal. I haven't looked into how shuffle is done though. But this seems like an elegant solution.

MeoMix commented 10 years ago

Yeah, that's definitely something I was considering :D It's not too hard to do.

fluke commented 10 years ago

I wouldn't know but yeah doesn't seem to be too hard :D. What else are you considering?

MeoMix commented 10 years ago

Mostly just making them independent from each other, but I think allowing shuffle to random into new songs is probably cooler.

The other issue is radio + repeat playlist. Probably shouldn't be able to toggle on radio with repeat enabled as it doesn't make sense.

On 8/29/14, Kartik Luke Singh notifications@github.com wrote:

I wouldn't know but yeah doesn't seem to be too hard :D. What else are you considering?


Reply to this email directly or view it on GitHub: https://github.com/MeoMix/StreamusChromeExtension/issues/280#issuecomment-53925134

fluke commented 10 years ago

Or you could just ignore repeat all but repeat one could still make sense. If you want to repeat a song in between.