search

MeoMix / StreamusChromeExtension

A YouTube video player as a Google Chrome extension
http://streamus.com
Apache License 2.0
1.08k stars 216 forks source link

Skip song when unable to be played #380

Open MeoMix opened 9 years ago

MeoMix commented 9 years ago

A lot of users would like Streamus to skip songs which aren't able to be played by Streamus.

The initial implementation of this was fairly naive. If multiple songs were unable to be played then it would skip through all of them, rapidly showing and hiding the dialog as it went. If shuffle/repeat were enabled then it would infinite loop.

Similarly, if someone's Internet died, suddenly all songs in the playlist would be unplayable and Streamus would skip through all of them. If Radio Mode was on then it would skip through a lot of Radio Mode songs, too.

It's certainly a good feature to implement, but the details are finicky.

silviubogan commented 9 years ago

+1 This can be left as an option that the user can enable if s/he wants.

silviubogan commented 9 years ago

Or you could pause the playlist to show a popup with a message for the user, and after a few seconds to automatically hide the popup and skip the unavailable song.

jonpaine commented 9 years ago

Hi - seems the UMG issue is giving usability a major hit. I think a shim on this issue could make a substantial usability difference in the short-term while a more comprehensive solution can be punted til later.

Any thoughts on just shimming your initial (immediate skip) implementation with a counter [n], so n=10 or 15 successive unable-to-be-played will lead to the popup. Any successful play resets [n] to 0. Might strike a nice balance making Streamus usable again while eliminating the various scenarios that lead to an infinite loop failure mode.

MeoMix commented 9 years ago

I've worked on Streamus for like... 35 hours out of my last 67 hours. I'm completely swamped on work and I'm expecting YouTube to contact me with some other concerns still this week. I have zero energy to try and add improve other functionality at this point in time. Sorry.

I'm sure there's lots of ways to do it, but I'd rather not code something half-assed only to have to re-code it later. I don't have the time to code stuff twice let alone once. :(

On Mon, Jul 6, 2015 at 11:57 AM, jonpaine notifications@github.com wrote:

Hi - seems the UMG issue is giving usability a major hit. I think a shim on this issue could make a substantial usability difference in the short-term while a more comprehensive solution can be punted til later.

Any thoughts on just shimming your initial (immediate skip) implementation with a counter [n], so n=10 or 15 successive unable-to-be-played will lead to the popup. Any successful play resets [n] to 0. Might strike a nice balance making Streamus usable again while eliminating the various scenarios that lead to an infinite loop failure mode.

— Reply to this email directly or view it on GitHub https://github.com/MeoMix/StreamusChromeExtension/issues/380#issuecomment-118958381 .

jonpaine commented 9 years ago

No worries. I get it.

I'm on vacation in a couple weeks and I have a strict no-work policy then, but I usually get antsy a couple days in. Maybe I'll take a look then and see if you'll accept a PR for someone elses half-assed shim. :)