search

MeowWolf / node-red-contrib-amqp

AMQP nodes for node-red
22 stars 18 forks source link

RabbitMq credentials on settings file doesn't work if login and password are differents #47

Closed cfeltz34 closed 3 years ago

cfeltz34 commented 3 years ago

On file Amqp.ts You have : 

  private getCredsFromSettings(): {
    username: string
    password: string
  } {
    return {
      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
      // @ts-ignore
      username: this.RED.settings.MW_CONTRIB_AMQP_USERNAME,
      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
      // @ts-ignore
      **password**: this.RED.settings.**MW_CONTRIB_AMQP_USERNAME**,
    }
  }

Please replace last line by **password**: this.RED.settings.**MW_CONTRIB_AMQP_PASSWORD**,

amodelbello commented 3 years ago

@cfeltz34 wow good catch! Frankly I can't believe this passed testing. Will have a fix as soon as I can.

amodelbello commented 3 years ago

@cfeltz34 Just pushed a new v2.4.1 version to npm. Please give it a try and see if the issue is fixed for you. Thanks again for letting us know about it!

cfeltz34 commented 3 years ago

Nice, that works. Thank you !