Meowhal / osu-ahr

irc bot for osu multi lobby auto host rotation
MIT License
129 stars 37 forks source link

SyntaxError: Unexpected token , in JSON at position 145 #147

Open Roboboy5741 opened 2 years ago

Roboboy5741 commented 2 years ago

this error shows up if you could contact me i can give you the full error message unless you already know this error and are able to fix

xayanide commented 2 years ago

Send the full error here. In this case, simply knowing the error message doesn't help a lot into making a solution, but I can tell that something undefined was passed to one of the JSON methods.

Does that error prevent you from starting the bot? Or does it just occur at irregular intervals while the bot is on and does not crash?

Roboboy5741 commented 2 years ago

i managed to fix the issue however i have come across another problem..... when setting a max star regulation (for example 2-3.99) people can use DT to break the system and play 3 maps at a 5* level

On Sun, 25 Sept 2022 at 22:29, Xayanide @.***> wrote:

Send the full error here. In this case, simply knowing the error message doesn't help a lot, but I can tell that something undefined was passed to one of the JSON methods.

— Reply to this email directly, view it on GitHub https://github.com/Meowhal/osu-ahr/issues/147#issuecomment-1257155580, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVO5URRNHTUQTEBUT3MTGTWAALQHANCNFSM6AAAAAAQO74V7E . You are receiving this because you authored the thread.Message ID: @.***>

xayanide commented 2 years ago

Oh that is good to know, can you send here how you managed to solve that issue?

As for the "max star regulation" issue you're currently having. On every beatmap pick this message is mentioned

"Attention! Star rating will not be calculated correctly if a global mod is applied."

The bot only compares the star rating of a beatmap to what star rating is shown in the website. The bot is unfortunately unable to base it off when a global mod like DT is applied.