Meowuu7 / GeneOH-Diffusion

[ICLR'24] GeneOH Diffusion: Towards Generalizable Hand-Object Interaction Denoising via Denoising Diffusion
https://meowuu7.github.io/GeneOH-Diffusion/
MIT License
76 stars 4 forks source link

I found some errors when I reproduced the GRAB example #1

Closed ldt29 closed 4 months ago

ldt29 commented 4 months ago

Run:

bash scripts/val_examples/predict_grab_rndseed_spatial_14.sh

Found:

predict_grab_spatial.py: error: unrecognized arguments: 0

In'scripts/val_examples/predict_grab_rndseed_spatial_14.sh', line 140, modify start_idx = 0 to start_idx = ""
Then modify prev_test_tag to the corresponding test tag

Run:

bash scripts/val_examples/reconstruct_grab_14.sh

Found:

File "~/GeneOH-Diffusion-main/sample/reconstruct_data_grab.py", line 1112, in get_optimized_hand_fr_joints_v4_anchors
    fvi, aw, _, _ = anchor_load_driver(inpath)
File "~/GeneOH-Diffusion-main/./utils/anchor_utils.py", line 13, in anchor_load_driver
    face_vert_idx, anchor_weight, merged_vertex_assignment, anchor_mapping = anchor_load(anchor_root)
File "~/GeneOH-Diffusion-main/./utils/anchor_utils.py", line 24, in anchor_load
    face_vert_idx = np.loadtxt(face_vert_idx_path, dtype=np.int)
File "~/miniconda3/envs/geneoh-diffusion/lib/python3.8/site-packages/numpy/lib/npyio.py", line 1308, in loadtxt
    arr = _read(fname, dtype=dtype, comment=comment, delimiter=delimiter,
File "~/miniconda3/envs/geneoh-diffusion/lib/python3.8/site-packages/numpy/lib/npyio.py", line 955, in _read
    fh = np.lib._datasource.open(fname, 'rt', encoding=encoding)
File "~/miniconda3/envs/geneoh-diffusion/lib/python3.8/site-packages/numpy/lib/_datasource.py", line 193, in open
    return ds.open(path, mode, encoding=encoding, newline=newline)
File "~/miniconda3/envs/geneoh-diffusion/lib/python3.8/site-packages/numpy/lib/_datasource.py", line 533, in open
    raise FileNotFoundError(f"{path} not found.")
FileNotFoundError: /home/xueyi/sim/CPF/assets/anchor/face_vertex_idx.txt not found.

In'sample/reconstruct_data_grab.py', line 1111, I found inpath = "/home/xueyi/sim/CPF/assets". but I can't find this directory.

Run:

python visualize/vis_grab_example_14.py

Found:

File "visualize/vis_grab_example_14.py", line 47, in get_mano_model
   mano_model = ManoLayer(
File "~/Gene0H-Diffusion-main/manopth/manopth/manolayer.py", line 65, in __init__
   smpl_data=ready arguments(self.mano_path)  
File "~/GeneOH-Diffusion-main/manopth/mano/webuser/smpl_handpca_wrapper_HAND_only.py", line 30, in ready_arguments  
   dd = pickle.load(open(fname_or_dict, 'rb'), encoding="latin1'  
FileNotFoundError: [Errno 2]No such file or directory: 'mano/models/MANO_RIGHT.pkl'

In "visualize/vis_grab_example_14.py", line 47: modify 'mano/models' to 'manopth/mano/models'

File "visualize/vis_grab_example_14.py", line 58, in vis_predicted_joints_grab  
ws = ws  
UnboundLocalError: local variable 'ws' referenced before assignment

Delete "visualize/vis_grab_example_14.py" line 58

Meowuu7 commented 4 months ago

Hi,

Thank you for your attention to our work and for bringing up the issue. I've tried to address your problem in my latest commit. Please try it again.

As I'm currently still in a rush to meet a deadline, my review may not have been as thorough as usual. I expect to have more time by next weekend to carefully review, fix potential problems, and refine this repository.

Please comment on this issue or contact me if you have any further question. Thank you!

Best regards

jiyewise commented 2 months ago

Hi, I found the same error (cannot find face_vertex_id.txt file) when trying to reproduce the full sequence version of the GRAB dataset. I run bash scripts/val/reconstruct_grab_fullseq.sh. How can I fix this? Thanks in advance!