Mephiles / torntools_extension

A browser extension for Torn.com
GNU General Public License v3.0
106 stars 62 forks source link

Fix open in new tab checkbox in sidebar custom links not displaying correct settings #681

Closed josephting closed 2 years ago

josephting commented 2 years ago

This was discovered and reported by DONCIC [2018849].

/pages/settings/settings.html?page=preferences&section=sidebar (Custom Links section)

The "open in new tab" checkboxes of saved custom links always displays as unchecked when loading the settings page. Custom links opens in new tab properly after checking the boxes and save the settings, until settings is saved next without having these checkboxes checked (making other setting changes).

image

Steps to reproduce

  1. Add custom links with open in new tab in torntools preferences; save preferences
  2. Refresh torntools preferences (can confirm checkbox is unchecked)
  3. At this point, the custom link added opens in a new tab
  4. Open torntools preferences page, change General -> Time to 12 hours or 24 hours (the currently unselected one) or any other settings to enable saving; save preferences
  5. The custom link that opened in a new tab at (3) no longer opens in a new tab