search

Mephiles / torntools_extension

A browser extension for Torn.com
GNU General Public License v3.0
106 stars 60 forks source link

Various Updates #741

Closed Vrasp closed 1 year ago

Vrasp commented 1 year ago

Not much to say that isn't in the commit messages. The userlist filtering is very useful for reviving factions, and the countdown fix is useful for anyone who leaves their tabs open while doing other things.

Sashank999 commented 1 year ago

Sorry for the late reply. I haven't been able to get some time from my real life.

For any feature, we usually discuss in Discord on where and how the feature has to be implemented, along with UI and default behaviour. In case of no discussion, we expect the PR to have minimum information about the feature, like intended uses and target audience. We don't directly look at the source code.

Resolve the merge conflicts and please change your indentation as per the repo's policies. A trailing newline for a file is mandatory. We use Prettier by the way.

Vrasp commented 1 year ago

No worries.

So, these are both fairly minor features which are more like additions to existing features than entirely new features.

Userlist filtering adds a new set of filtering options on the userlist page, with the default being to not filter any of them out. It uses the same filtering box as the existing filtering on the page. As stated in the initial PR, this feature is intended to be used by reviving factions, as many revive contracts have certain such parameters as "hospitalized by" only, ie no leaves/mugs/etc.

The Faction OC Timer is placed on the sidebar in the same area as the personal OC timer, and the feature defaults to off, since it's only useful for people who have permissions to initiate the OCs. This feature is intended to assist people in running their faction OCs on time.