search

Mephiles / torntools_extension

A browser extension for Torn.com
GNU General Public License v3.0
106 stars 60 forks source link

removed console.log #749

Closed oliverkoehler closed 1 year ago

oliverkoehler commented 1 year ago

Hey there, i removed the console.log due its very spamy:

image

Kwack-Kwack commented 1 year ago

These are there for a reason, you can filter them out in the chrome console (right click on one and select hide messages from featureManager.js).

However, TT does have a (hidden) setting developer (bool), removing the logs unless manually flagged as a developer could be an option?

oliverkoehler commented 1 year ago

yeah that sounds good for me, ill work an this change.

Kwack @.***> schrieb am So., 21. Mai 2023, 23:30:

These are there for a reason, you can filter them out in the chrome console (right click on one and select hide messages from featureManager.js).

However, TT does have a (hidden) setting developer (bool), removing the logs unless manually flagged as a developer could be an option?

— Reply to this email directly, view it on GitHub https://github.com/Mephiles/torntools_extension/pull/749#issuecomment-1556296650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEPB74BR772WMPR7KLYWPTTXHKCOPANCNFSM6AAAAAAYJUHKMU . You are receiving this because you authored the thread.Message ID: @.***>

Sashank999 commented 1 year ago
  1. It is not at all bothering the regular user.
  2. It gives developers a lot of fruitful information when any user comes to us for resolving their bug.
  3. Its asynchronous so it doesn't have much performance penalty.
  4. Logging into the console is a good practice rather than looking at the Sources in Chrome DevTools.

Sorry but this isn't going to be accepted. I intend to have the logs.