Merathilis / ElvUI_MerathilisUI

MerathilisUI is an external ElvUI Mod. It adds some usefull and probably not some usefull (lol) additions to ElvUI.
https://www.curseforge.com/wow/addons/merathilis-ui
MIT License
27 stars 13 forks source link

Spell Feedback issues #34

Closed VaporAPX closed 2 years ago

VaporAPX commented 2 years ago

What is the issue you are having?

Cannot disable spell feedback/key feedback. Doing so reload's the UI, but the options are re-enabled after reload. Having spell feedback enabled causes conflict with Omnicc addon. The cooldown timers from the mod no longer show on my weakaura buttons and only show on the spell feedback button when enabled. Disabling the UI fixes the problem.

What is the expected behavior?

Should be able to disable spell/key feedback, and not have any conflict with the Omnicc cooldown addon.

What actually happened?

As stated above, cannot disable spell/key feedback and having it enabled causes Omnicc to not show cooldown numbers on my weakauras, only the newly created button from feedback.

Suggested Solution/Workaround

No response

Errors

No response

ElvUI Changelog/Troubleshooting

VaporAPX commented 2 years ago

Upon further testing, having feedback enabled still has the Omnicc cooldown numbers showing on actionbars. It only seems to remove them from weakauras.

VaporAPX commented 2 years ago

Reverted back to 5.20. Spell feedback allows me to disable and does not cause any conflicts. Whatever changed from Spell feedback in 5.20 and keyfeedback in 5.21 is the issue.

Merathilis commented 2 years ago

This is already fixed in my dev. version. I just forgot to remove the old options for it, just scroll a bit down in the ActionBar options and you find the new options.

VaporAPX commented 2 years ago

I downloaded the dev version and tried that as well. The option to remove Spell feedback is gone, but disabling Key Feed back still causes the issue with Omnicc. It does however disable the keyfeedback frame from showing.

Merathilis commented 2 years ago

Keyfeedback hast nothing to do with it, look under Skins/AddOns and untick WeakAura Cooldowns

VaporAPX commented 2 years ago

That did indeed fix it. Apologies, it seemed like the issue was stemming from the keyfeedback option as this was the only thing I noticed to be different. Thanks for your time and hard work. Love the layout.