Closed cemyl95 closed 2 months ago
Merathilis
commented
2 months ago This is mostly because you are not using the recommended scale for your Resolution. Blizzard changed the size from the GameMenu by default. So i also had to adjust my code for it. So there is nothing really i can't do against it.
cemyl95
commented
2 months ago I turned down the scaling in the settings as low as I could and the issue persists. It gets a little better when I turn down the ElvUI scaling settings but only if I scale it down to the point where I can barely see anything.
cemyl95
commented
2 months ago Did some additional research - The addon API has a function GetCurrentResolution, so you'd definitely be able to add in some logic to scale down the game menu style over X resolution. The style appears normally at full HD but anything above that (QHD/UHD) don't scale properly and would need to be scaled down. Here's the link to the function reference: https://addonstudio.org/wiki/WoW:API_GetCurrentResolution
cemyl95
commented
2 months ago Alternatively, you could add a setting into the MUI settings menu to allow adjusting the scaling of the game menu. Default it to 1x and let people scale it down (or up) as they wish. Or, you could tie it to the new Game Menu Scale option in ElvUI (if they scale down the game menu in ElvUI, then match that scaling in the MUI styling)
cemyl95
commented
2 months ago I made a (very very dirty) proof-of-concept of scaling the game menu style. I modified Modules/Misc/GameMenu.lua lines 59, 69, 113, 123, and 143 by multiplying the values by 0.5. This successfully scales down the game menu style such that it's not blocking the game menu.
I'm not very experienced with addons (or Lua in general) so I'll leave a proper implementation to the experts but at the very least we know for sure it can be done!
Merathilis
commented
2 months ago I made a (very very dirty) proof-of-concept of scaling the game menu style. I modified Modules/Misc/GameMenu.lua lines 59, 69, 113, 123, and 143 by multiplying the values by 0.5. This successfully scales down the game menu style such that it's not blocking the game menu.
I'm not very experienced with addons (or Lua in general) so I'll leave a proper implementation to the experts but at the very least we know for sure it can be done!
I never said it can't be done. But since i can only test it on 1080p it is hard to test for me. Also the API you are mentioned, is one, which might not the correct one in this case, ElvUI have own function/api's also to use. And, if you are not using the recommended scale for your resolution, its basically not doable at all, since i take account to pixel perfect scale, and i will not break it.
I will look into it, but i dont promise anything.
Merathilis
commented
2 months ago https://github.com/Merathilis/ElvUI_MerathilisUI/commit/3965979a1f66599dc9deb78aba4811839d0283a4
I just changed it to use the real screen width/height instead of the physical one. Please download my dev version and test it. For any other questions, please join my Discord.
cemyl95
commented
2 months ago works perfectly. thank you!
What is the issue you are having?
Since the release of TWW (or maybe shortly before, I've been away from wow for a few months), the MerathilisUI game menu style is too big (the translucent top/bottom bars) and because of this the MerathilisUI logo partially covers the game menu. This is on a 4k screen.
What is the expected behavior?
The bottom/top bars should not cover the game menu.
What actually happened?
The top/bottom bars and MerathilisUI logo cover the game menu.
Suggested Solution/Workaround
Adjust scaling (or provide a setting to adjust scaling) of the game menu style.
Errors
No response
ElvUI Changelog/Troubleshooting
/muidebug on? This is important in order to rule out that any of your other addons are causing the issue. If you manage to pinpoint a conflict between ElvUI and/or MerathilisUI and another addon, make sure you include that information.