search

MerchantPug / apugli

An extension to Apoli for certain mods' use.
MIT License
5 stars 4 forks source link

Mod still performs server/client version check when nested on Quilt. #18

Closed MerchantPug closed 1 year ago

MerchantPug commented 2 years ago

Despite my best efforts, I have not been able to disable the server check when the mod is nested on Quilt.

This is non fatal at least but this will run on Quilt, it's not fatal, however I am unsure what a Quilt friendly way of checking if the mod is nested except for making a Quilt version of the mod, which I'd prefer not to do as Apoli/Origins doesn't have its own Quilt version.

This is due to Fabric's ModOrigin class always being UNKNOWN on Quilt.

MerchantPug commented 2 years ago

I could also easily remove this bit of code but then again, I'd rather have this here so the server isn't checking versions for two mods when one is nested.

MerchantPug commented 1 year ago

This functionality has been removed, so we can close this issue.