search

MerchantPug / apugli

An extension to Apoli for certain mods' use.
MIT License
5 stars 4 forks source link

modify_enchantment_damage_dealt doesn't work #33

Closed DaedalusGame closed 1 year ago

DaedalusGame commented 1 year ago

Once again using the example from here and forge 1.19.2, it doesn't crash anymore but twiddling with the values it also doesn't seem to do anything at all, the damage stays constant at its vanilla value.

I'm also not sure what its supposed to do, is it just a shorthand for modifying the damage but with filtering for the user's enchantment or does it actually mixin the damage modifier formula for sharpness/bane of arthropods/smite/...?

MerchantPug commented 1 year ago

On Forge, it modifies the damage through an event.

base_value is the damage at level 1. With any more levels, the modifier is applied as many times as more levels there are.

MerchantPug commented 1 year ago

Thank you for the report though, I should really stop assuming things work after one fix.

MerchantPug commented 1 year ago

I was accidentally setting the power to equal the modify enchantment damage taken amount, which would be 0 without any of those powers.

This has now been fixed.

MerchantPug commented 1 year ago

Fixed in v2.1.0