search

MerchantPug / apugli

An extension to Apoli for certain mods' use.
MIT License
5 stars 4 forks source link

`apugli:edible_item` incompatibility with Collective #9

Closed Davithy closed 2 years ago

Davithy commented 2 years ago

Less of a bug and more of a feature request. As the title says, I'd like for the edible item power to work with the minecraft:used statistic so that it can be used to track for achievements! Probably incredibly niche ask so it's okay if it's not something you end up working on, but thought I'd suggest!

MerchantPug commented 2 years ago

Thanks for suggesting this!

I was suggested this in my own discord and was going to implement it but I never got around to it and forgot about it

Davithy commented 2 years ago

Haha, that was actually me! I wanted to formally place it in as a request here and be official about it. I'll keep an eye out on the future updates!

MerchantPug commented 2 years ago

This already seems to be a feature in the latest Apugli (ever since I refactored the edible item code)

Davithy commented 2 years ago

Awesome!! Thanks for letting me know, I'll happily close this "issue" 👍

MerchantPug commented 2 years ago

I'm fixing some bugs with it rn but it should be functional

Davithy commented 2 years ago

so in my short time testing it, I have found that in an isolated environment with just origins and apugli, it works great just as advertised, but after adding the mods I intend to use in a pack, something seems to prevent the edible item power from working properly. Essentially, the player will act as though the item is being eaten, but the item will not be eaten, hunger will not be given, and the item used counter doesn't increase. I'll try to find the mod that's causing this issue, but I won't reopen this issue quite yet unless I can confirm it's an issue with apugli or the unnamed mod.

Davithy commented 2 years ago

okay, I believe it's the collective api made by Serilum. Removing the collective-fabric-1.18.x-4.26.jar from my mods seems to properly give the edible item power its functions back, and replacing it should replicate the issue if you want to give it a check!

MerchantPug commented 2 years ago

https://github.com/ricksouth/serilum-mc-mods/issues/1094

I've filed a bug report for Collective. I'll be increasing my mixin's priority in the meantime for the next update.

MerchantPug commented 2 years ago

https://github.com/ricksouth/serilum-mc-mods/issues/1094#issuecomment-1250062010

Apparently it has been fixed here. I'll check in a test world to make sure nothing is broken on my end before closing this issue.

MerchantPug commented 2 years ago

Confirmed fixed.