Merck / gsDesign2

Group Sequential Design Under Non-Proportional Hazards
https://merck.github.io/gsDesign2/
GNU General Public License v3.0
19 stars 8 forks source link

Class of `gsDesign2` and `simtrial` #457

Open LittleBeannie opened 4 weeks ago

LittleBeannie commented 4 weeks ago

In the current version of gsDesign2, we have the class of

In the current version of simtrial, we have the class of

Two questions:

  1. Will additional classes be included in gsDesign2 or simtrial?
  2. Some keywords, such as 'gs', 'fixed', and 'wlr', are common to both gsDesign2 and simtrial. What is the recommended naming convention to distinguish classes from gsDesign2 or simtrial?
jdblischak commented 4 weeks ago

I agree this is an important discussion to have. The class system in {gsDesign2} is complex.

Some additional high-level questions I have:

  1. How are the classes used? In other words, which classes have registered S3 methods, and which are detected inside of functions with inherits() or %in% class()? And for the latter, can we redesign the functions to use S3 methods instead of these ad-hoc class-specific code chunks?
  2. How are the classes related to each other? In other words, are some classes always accompanied by other classes, and thus are more like sub-classes? If yes, then this would inform the potential redesign from the previous point
jdblischak commented 2 weeks ago

Waiting on #461/#282 first for @yihui to refactor the summary() methods