Import all functions once in `R/gsDesign2-package.R`, and remove the `pkg::` qualifiers

Merck / gsDesign2

Group Sequential Design Under Non-Proportional Hazards

https://merck.github.io/gsDesign2/

GNU General Public License v3.0

19 stars 8 forks source link

Import all functions once in `R/gsDesign2-package.R`, and remove the `pkg::` qualifiers #464

Closed yihui closed 2 months ago

nanxstats commented 2 months ago

Apparently this is more of a personal preference and style guide thing so I'm afraid I can't be very helpful here.

The R Packages book dependencies chapter currently pushes a style that qualifies external namespaces with ::, without adding to NAMESPACE by default, unless it's used "a lot" or an operator. However, I don't think it's strictly enforced in their packages.

yihui commented 2 months ago

I don't really have a strong opinion on this. My original motivation was that I saw sometimes we use dplyr::, and sometimes we don't, so I wanted to clean up the unnecessary dplyr:: qualifiers. Then I moved on to remove other package qualifiers.

jdblischak commented 2 months ago

The R Packages book dependencies chapter

Later in that section, they also support defining @importFrom either separately for each function or in a central location. Thus I'm fine with migrating to the central location style.