Merck / metalite.ae

An R package for standard adverse events analysis
http://merck.github.io/metalite.ae/
GNU General Public License v3.0
17 stars 4 forks source link

Remove dependencies on dplyr and tidyr #136

Closed BrianLang closed 1 year ago

BrianLang commented 1 year ago

This PR removes dependencies on dplyr and tidy from metalite.ae The hard dependencies were removed from the following functions:

Additionally, there was need to update avg_event and avg_duration.

Also I removed the need for dplyr in the function examples.

BrianLang commented 1 year ago

Well, now we know it screwed other things up. Will look.

BrianLang commented 1 year ago

So upon digging in, I found that these functions avg_event and avg_duration do not do any controlled sorting of the output. While you would have expected the output to be in the same sort order as the input, or perhaps an alphabetical sort order, this was not the case. I've updated these functions and their testing to maintain sort order of output to be consistent with the input par argument.

The function extend_ae_specific uses these functions but has not been tested in a way that would uncover this issue.

BrianLang commented 1 year ago

This looks good to me. Thanks for reducing the number of hard dependencies!

Would be happy for some feedback on my approach and implementation if you can find time.

nanxstats commented 1 year ago

This looks good to me. Thanks for reducing the number of hard dependencies!

Would be happy for some feedback on my approach and implementation if you can find time.

Sure, I've scheduled some time next week.