Merck / metalite.ae

An R package for standard adverse events analysis
http://merck.github.io/metalite.ae/
GNU General Public License v3.0
17 stars 4 forks source link

142 add exposure adjusted adverse event summary table #146

Closed louisbingley1 closed 1 year ago

fb-elong commented 1 year ago

Major

  • Is rlang::eval_tidy() evaluating arbitrary input expressions? That would create a security vulnerbility, as the expression can be malicious.

Move this into an independent package design issue in #153. It will impact many functions we are developing.

louisbingley1 commented 1 year ago

Thanks everyone for the inputs/suggestions. This merging action was a mistake, and I apologize. I was trying to get familiar with Github and I wanted to practice how to pull/merge and see what happens after merging, just out of curiosity. I didn't realize the current branch is not ready to merge yet (with lots of issues to be fixed), neither did I realize that all of you will get notified of my pull/merge request with all the errors reported and everything. I'll close the merge request for now. Sorry again about causing all the concerns!