search

Merck / metalite

An R package to create metadata structure for ADaM data analysis and reporting
https://merck.github.io/metalite/
GNU General Public License v3.0
15 stars 6 forks source link

add label attribute #74

Closed LittleBeannie closed 2 years ago

nanxstats commented 2 years ago

Is data_observation a data frame? Do we need drop = FALSE here? Plus, there is a typo "lable".

LittleBeannie commented 2 years ago

Is data_observation a data frame? Do we need drop = FALSE here? Plus, there is a typo "lable".

Yes, data_observation is a data frame. Could you be more specific about drop = FALSE?

nanxstats commented 2 years ago

Is data_observation a data frame? Do we need drop = FALSE here? Plus, there is a typo "lable".

Yes, data_observation is a data frame. Could you be more specific about drop = FALSE?

https://adv-r.hadley.nz/subsetting.html#simplify-preserve

fb-elong commented 2 years ago

We probably should move the two functions below into metalite and apply it here.

https://github.com/elong0527/metalite.table1/blob/main/R/label.R

LittleBeannie commented 2 years ago

Hi @elong0527/ @fb-elong and @wangben718 , is this PR ready to be merged?