search

Merck / metalite

An R package to create metadata structure for ADaM data analysis and reporting
https://merck.github.io/metalite/
GNU General Public License v3.0
15 stars 6 forks source link

independent testing for meta_run() #75

Closed howardbaik closed 2 years ago

howardbaik commented 2 years ago

All tests passed. Snapshot testing followed Basic Workflow.

LittleBeannie commented 2 years ago

Hi @howardbaek , thanks for the validation. There are 2 issues that need to be solved before we merge.

  1. CMD check: Message: could not find function "ae_summary"
  2. Please rename test-meta_run.R into test-independent-testing-meta_run.R
howardbaik commented 2 years ago

@LittleBeannie Do I need to define ae_summary anad ae_specific inside each test_that function? Also, I've renamed test-meta_run.R into test-independent-testing-meta_run.R

LittleBeannie commented 2 years ago

@LittleBeannie Do I need to define ae_summary anad ae_specific inside each test_that function? Also, I've renamed test-meta_run.R into test-independent-testing-meta_run.R

As long as you can pass the CMD check. The ae_summary is indicated by the error message. Just for your reference to fix the CMD check.

nanxstats commented 2 years ago

You might find the testthat testing fixtures article informative about the best practices.

elong0527 commented 2 years ago

Any plan to fix the CI/CD issue and close the PR?

howardbaik commented 2 years ago

Yep, I'll work on it this week.