Merck / r2rtf

Easily Create Production-Ready Rich Text Format (RTF) Table and Figure
https://merck.github.io/r2rtf
GNU General Public License v3.0
76 stars 19 forks source link

Rtf rich text #184

Closed BrianLang closed 1 year ago

BrianLang commented 1 year ago

I've made the updates to remove dependencies and also resolved an issue with brace matching. Previously nesting of braces mixing rtf_text code like {.emph text{^\\dagger}} would end up matching the wrong braces and producing unexpected rtf output. Now it correctly resolves pairs of braces with FILO.

closes #112 closes #185

BrianLang commented 1 year ago

Thanks for the updates @nanxstats . Do you have your own styler config? Or do you adapt these changes by hand? Agree that they look better.

nanxstats commented 1 year ago

Thanks for the updates @nanxstats . Do you have your own styler config? Or do you adapt these changes by hand? Agree that they look better.

Good question! styler can apply the general style guide but it is not aggressive (probably to be on the safe side). For example, it doesn't know if new lines should be added or removed, and if words are properly stylized under the context.

In those cases, I just apply the more comprehensive guides from the original tidyverse style guide manually when appropriate. That is ok because I think clean code / code style should be decided by humans ultimately, although automated rules surely help reduce manual work.

elong0527 commented 1 year ago

Looks great! Thanks a lot for handling the task.

BrianLang commented 1 year ago

Thanks @nanxstats and @elong0527

nanxstats commented 1 year ago

@BrianLang This sounds like a excellent topic for an external blog post or vignette. It's super ✨visual✨