Update GitHub Actions workflows to upstream latest versions

nanxstats commented 5 months ago

This PR updates all GitHub Actions workflows to their latest versions from upstream (r-lib/actions).

The upstream changes mostly involves updating actions/checkout and actions/upload-artifact to v4, which updated the default runtime to Node.js 20.

I just ran

usethis::use_github_action("check-standard")
usethis::use_github_action("pkgdown")
usethis::use_github_action("test-coverage")
usethis::use_github_action("style")

Also, this fixes #213.

nanxstats commented 5 months ago

The segmentation fault you see in macOS is similar to https://github.com/tidyverse/dplyr/issues/6961. Not related to the PR.

nanxstats commented 5 months ago

I created an issue on a possible cause after looking into the problematic test file: https://github.com/Merck/r2rtf/issues/213 Not entirely sure if it's relevant.

nanxstats commented 5 months ago

OK, here is what I found and did to improve the testing situation, now this is ready:

Removing the unnecessary svg() and dev.off() calls (https://github.com/Merck/r2rtf/pull/212/commits/dbb3c0357f8cd148ebfd9806e4feac5248a07a1a) resolved the macOS segmentation fault. This is the culprit.
I further removed the library() calls from tests/testthat.R, individual tests, and qualified the involved namespaces in tests (https://github.com/Merck/r2rtf/pull/212/commits/789611170f6c939662c440206c122edafc64be96) following the standard.
Additionally, I used the testthat native mechanism skip_if_not_installed() to replace requireNamespace() in the tests driven by officer (https://github.com/Merck/r2rtf/pull/212/commits/f808ad191fec9115ab49638e84cd6e370ef70259).

Merck / r2rtf

Update GitHub Actions workflows to upstream latest versions #212