Merck / r2rtf

Easily Create Production-Ready Rich Text Format (RTF) Table and Figure
https://merck.github.io/r2rtf
GNU General Public License v3.0
76 stars 19 forks source link

Unnecessary SVG saving in tests? #213

Closed nanxstats closed 5 months ago

nanxstats commented 5 months ago

These tests started with svg(tempfile("tmp.svg")):

https://github.com/Merck/r2rtf/blob/b3378df9c81eecae79c4a527a37c3095176570ab/tests/testthat/test-independent-testing-rtf_nrow.R#L2

https://github.com/Merck/r2rtf/blob/b3378df9c81eecae79c4a527a37c3095176570ab/tests/testthat/test-independent-testing-as_rtf_pageby.R#L2

and ended with dev.off() at the end of the file. It's unclear why these are necessary.