search

Merck / r2rtf

Easily Create Production-Ready Rich Text Format (RTF) Table and Figure
https://merck.github.io/r2rtf
GNU General Public License v3.0
76 stars 19 forks source link

Some minor tweaks for convert() #217

Closed yihui closed 3 months ago

yihui commented 3 months ago

I'm proposing some minor changes while looking at #216 (these changes are irrelevant to #216, though):

  1. Use requireNamespace() to test if stringi is available.
  2. Reduce one ifelse() call.
  3. Use the safer seq_along(x) instead of 1:length(x).
yihui commented 3 months ago

(The R CMD check error was due to the secondary dependency of emmeans (estimability) requires R >= 4.3.0 while the current r-oldrel is only 4.2.x. The issue will go away once R 4.4.0 is released.)

If we use emmeans conditionally in the package, it should pass R CMD check in Github actions (with 5302ee7).