search

Merck / simtrial

Clinical trial simulation for time-to-event endpoints
https://merck.github.io/simtrial/
GNU General Public License v3.0
18 stars 8 forks source link

Enhancement for doFuture implementation and stable parallel RNG in sim_gs_n #230

Closed cmansch closed 5 months ago

cmansch commented 6 months ago

Implementation for sim_gs_n() to have a parallel adaptor similar to sim_fixed_n() (xref: https://github.com/Merck/simtrial/pull/110). A seed is now set prior to the function call instead of passed as an argument. Function now uses %douture% to run iterations of n_sim in parallel.

Addresses open issue (xref: https://github.com/Merck/simtrial/issues/205).

Sequential backend still available (and default) to avoid any delays in development.

Please update "Remove seed argument from sim_gs_n() in (xref: https://github.com/Merck/gsDesign2/issues/288) as part of the implementation.

PR will be updated again following approval of PR (xref: https://github.com/Merck/simtrial/pull/229) as it will need to combine updates to sim_gs_n from that PR.

jdblischak commented 6 months ago

My PR #229 has been merged. @cmansch could you please update your PR? I recommend fixing the roxygen2 comments first since that should reduce the number of merge conflicts you'll have to address manually