Closed nanxstats closed 6 months ago
We have multiple PRs currently open (#229, #230, #233). If we have until May 4th to submit the update to CRAN, which of these PRs do we want to include?
We have multiple PRs currently open (#229, #230, #233). If we have until May 4th to submit the update to CRAN, which of these PRs do we want to include?
I guess we can at least merge #233 , which is only 1 line change of codes. Both #229 and #230 are for sim_gs_n
. I will check with Keaven if he agrees to merge or plan to test them and save them for the next CRAN release.
We received some feedback from the bshazard maintainers that they will resubmit to CRAN soon. Let's wait a few days but still make a plan on what to merge. If nothing happens until next week, we make a release.
Thanks for the summary, @nanxstats!
I discussed the 3 open PRs with Keaven during the lunch hour and arrived at the conclusion that #233 will be in this CRAN release. And #230 and #229 will save for next CRAN release. Hope this plan works for both you and @jdblischak.
Since the noSuggests
checks failed and 0.4.0 was rejected by CRAN, we will make another release (0.4.1).
Prepare for release
cran-comments.md
(optional)urlchecker::url_check()
Submit to CRAN
Wait for CRAN