Follow up to #273. Now that wlr() returns different columns compared to rmst() and milestone() (and thus the outputs are no longer standardized, #222), @LittleBeannie suggested filling the missing columns with NAs (https://github.com/Merck/simtrial/pull/273#issuecomment-2299109281).
This PR replaces rbind() with data.table::rbindlist() to allow combining test functions that return different functions. I restored the sim_gs_n() tests to confirm this is working.
Note that unfortunately it is still not possible to combine the results of maxcombo() because its z column is a list column. I think I'll be able to get this working, but it will require additional code and tests, so I decided to keep it separate from this PR.
Follow up to #273. Now that
wlr()
returns different columns compared tormst()
andmilestone()
(and thus the outputs are no longer standardized, #222), @LittleBeannie suggested filling the missing columns withNA
s (https://github.com/Merck/simtrial/pull/273#issuecomment-2299109281).This PR replaces
rbind()
withdata.table::rbindlist()
to allow combining test functions that return different functions. I restored thesim_gs_n()
tests to confirm this is working.Note that unfortunately it is still not possible to combine the results of
maxcombo()
because itsz
column is a list column. I think I'll be able to get this working, but it will require additional code and tests, so I decided to keep it separate from this PR.xref: #229, #258